-
Notifications
You must be signed in to change notification settings - Fork 35
Simplify getenv call using cstdlib #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, If the CI is green.
|
CI isn't happy. Looks like double free? (reference: https://github.com/compiler-research/CppInterOp/actions/runs/17621310446/job/50070564052?pr=709#step:12:725). |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
There might be some chances that the failures are not introduced by this PR; instead, it is due to the thread-safety PR. Will need to do some local testing to figure it out. |
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Its not at all clear why the error is happening in the ci about frontend::IndexHeaderMap for llvm=20. That section of code shouldn't even be compiled for llvm=20 (see https://github.com/ferdymercury/CppInterOp/blob/87c288becb93ba23b3f6b818cdc80c93b23c69e2/lib/CppInterOp/Paths.cpp#L195) . |
Description
Partially reverts c0a4dfe#diff-9e2485d191b0ee5c98436db2e99b854b71c96f67cb1d8b42870744ffbbe31acc
Is motivated by root-project/root#19864
Type of change
Simplification
Testing
see ROOT CI PR
Checklist